keep fly check resource until it succeed in downgrade/upgrade job #3504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rui Yang <ryang@pivotal.io>
|
I started on a cleanup of the Docker Compose setup that I think might remove the need for this, fwiw. I'll have something to push soon - just doing some local manual testing. edit: #3510 |
|
As #3510 is merged this PR shouldn't be needed anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to #3494
There is a chance that
fly check resourcefailed when looking up existing check container on an already-removed worker.This won't be an issue anymore if #3079 is done. Since the very first
fly check resourceafter downgrade would just spin up a new check container instead of using the old one.