Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for multiple redirect URIs #11994

Merged

Conversation

KorvinSzanto
Copy link
Member

@KorvinSzanto KorvinSzanto commented Mar 18, 2024

This PR does a few things to better support multiple redirect URIs:

  1. Switch from type='uri' to a basic pattern that forces the string to start with http:// or https://
  2. Use text column type for redirects so that we can fit longer redirect uris than 255 chars
  3. Update the form validation for save to validate the URIs individually rather than as a single string
  4. Adds a migration to handle upgrade

The effect of those changes is I can have as many redirect URIs as I want.

aembler added a commit that referenced this pull request May 7, 2024
@aembler aembler merged commit d76bc48 into concretecms:9.2.x May 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants