Add nullable type to types that will throw deprecation errors in PHP 8.4 #12023
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents the upcoming php 8.4 deprecation errors caused by nullable parameters being typed without a nullable type.
Interestingly, this also uncovered a couple places where constructors had parameters with default values before parameters without default variables, which is also deprectated. See eb938a6 and c1a6a57 for the specific backwards-compatible fixes for that
Fixer can be seen here: https://gist.github.com/KorvinSzanto/13eed5210561f6d090b159eae65b93a6
See https://wiki.php.net/rfc/deprecate-implicitly-nullable-types for more info