Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow colon in custom class names #12027

Closed
wants to merge 3 commits into from
Closed

Allow colon in custom class names #12027

wants to merge 3 commits into from

Conversation

shahroq
Copy link
Contributor

@shahroq shahroq commented Apr 12, 2024

Fix for #12021.

@shahroq shahroq mentioned this pull request Apr 12, 2024
Closed
@KorvinSzanto
Copy link
Member

It might be good to also add [] so that tailwind's arbitrary values are supported too https://tailwindcss.com/docs/adding-custom-styles#using-arbitrary-values

@shahroq
Copy link
Contributor Author

shahroq commented Apr 12, 2024

@KorvinSzanto Brackets added.

@shahroq
Copy link
Contributor Author

shahroq commented Apr 15, 2024

Re the c5dragon comment on #12021 :

3rd commit: if intended to support space between.

It separates before validation, so unlike the previous version, in cases like this class-1 2-class, the second class will be ignored.

aembler added a commit to aembler/concretecms that referenced this pull request May 7, 2024
@aembler
Fix concretecms#12021; Supersedes concretecms#12027
bb4338a
aembler added a commit that referenced this pull request May 7, 2024
@aembler
Merge pull request #12056 from aembler/fix-12021
fc87740 
Fix #12021; Supersedes #12027
@aembler
Copy link
Member

aembler commented May 7, 2024

Superseded by #12056

@aembler aembler closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KorvinSzanto KorvinSzanto KorvinSzanto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shahroq @KorvinSzanto @aembler