Test that migrations are marked as repeatable #6637
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we create a new migration, 99% of times it is repeatable, so let's add a test case to check this.
This new test case checks that all migrations are marked as repeatable, except the ones explicitly listed in the
$allowedNotRepeatableMigrations
property of this newRepeatableMigrationsTest
test.This new test case helps a lot avoiding problems like these:
Marking migrations as repeatable is very important, because the
--rerun
option of thec5:update
command can re-execute migrations only if they are repeatable, and all the next migrations are repeatable.For instance, if we have migrations M1, M2, M3, M4, M5, and M3 is not marked as repeatable, the
--rerun
option will let you rerun only re-execute migrations M4 and M5.PS: this PR should fail, since #6636 is not merged yet.