Make RTL and font-family properties work with iOS #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make RTL and font-family properties work with iOS.
cooperka
reviewed
Aug 31, 2021
There was a problem hiding this comment.
Thanks for this @Mahmoud-El-Sayed-92! It looks good, I'll test it on my emulator as soon as I can, and then release this.
If you're able to, could you please also update the README to remove the "Android only" text for these parameters? Documentation is important! Cheers.
| @@ -262,7 +262,8 @@ - (void)show { | |||
|
|
|||
| id textColor = _pendingOptions[@"textColor"]; | |||
| self.textColor = textColor ? [RCTConvert UIColor:textColor] : [UIColor whiteColor]; | |||
|
|
|||
| textLabel.font = [UIFont fontWithName:_pendingOptions[@"fontFamily"] size:15]; | |||
There was a problem hiding this comment.
Clarifying question: do you know that 15 is the default size? Why does this need to be explicitly set?
cooperka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make RTL and font-family properties work with iOS.