plugin/kubernetes: add dup endpoint name test #1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution. I've just checked the OWNERS files to find a suitable reviewer. This search was successful and I've asked bradbeam (via plugin/kubernetes/OWNERS) for a review. |
Codecov Report
@@ Coverage Diff @@
## master #1811 +/- ##
=======================================
Coverage 54.27% 54.27%
=======================================
Files 192 192
Lines 9485 9485
=======================================
Hits 5148 5148
Misses 3943 3943
Partials 394 394Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. What does this pull request do?
Adds a test to verify proper duplicate endpoint hostname behavior.
2. Which issues (if any) are related?
kubernetes/dns#116
3. Which documentation changes (if any) need to be made?