RCBC-451 & RCBC-452: Expose any specific lookup_in spec errors #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
DemetrisChr
changed the title
avsej
reviewed
Aug 17, 2023
avsej
reviewed
Aug 17, 2023
avsej
reviewed
Aug 17, 2023
avsej
reviewed
Aug 17, 2023
Co-authored-by: Sergey Avseyev <sergey.avseyev@gmail.com>
avsej
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Any spec-specific errors were ignored which resulted in any error that happens being exposed
PathNotFound(because of the absence of content)Changes
Add an
errorattribute to theSubDocumentFieldclass that stores the Ruby error that is equivalent to the spec-specific error code from the C++ response. This error is raised thencontentorexists?for that spec are called