RCBC-450: Set value of subdoc exists to true or false if result is success or path-not-found #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ccess or path-not-found
|
Can one of the admins verify this patch? |
DemetrisChr
commented
Sep 18, 2023
| rb_hash_aset(entry, value_property, cb_str_new(resp_entry.value)); | ||
| } | ||
| if (resp_entry.ec && resp_entry.ec != couchbase::errc::key_value::path_not_found) { | ||
| if (resp_entry.ec) { |
There was a problem hiding this comment.
There is no need for this check now that C++ clears path_not_found status codes for exists specs
DemetrisChr
commented
Sep 18, 2023
| return false unless field | ||
|
|
||
| raise field.error unless field.error.nil? | ||
| raise field.error unless field.error.nil? || field.error.is_a?(Error::PathNotFound) |
There was a problem hiding this comment.
The core can return path_not_found status codes if those are coming from get or count operations. Those should not be raised if #exists is called - they should only be raised for #content
avsej
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring in changes from couchbase/couchbase-cxx-client#452 and make any necessary wrapper-side changes.
When calling
#contentfor an exists spec the result is the same as the result of#exists, provided that the subdoc operation was successful or the error was path-not-found (otherwise an error is raised), which is required to be compliant with the RFC. Previously, a PathNotFound error was raised when the path did not exist. This logic is handled by the C++ core