Same named tests covering up mismatched exception test on no id found. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing Couchbase::Model subclasses, when using Rails.
|
I have fixed this issue in http://review.couchbase.org/24684, but could you extract the changes about logging into the separate commit and upload to out review system? We have a document about how to make a contribution https://github.com/couchbase/couchbase-ruby-model/blob/master/CONTRIBUTING.markdown |
|
@ingenthr I think this ticket might be closed, because original issue has been fixed |
|
I should have closed this a while ago... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not really sure if Couchbase::Model's Couchbase::Error::MissingId or the Couchbase gem's Couchbase::Error::NotFound exception should actually be raised here. Changed it to NotFound in the test so it would pass.