New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6702] Image cropper increases size of an image relative to the original #3843

Merged

sumerjabri merged 1 commit into craftercms:develop from jvega190:bugfix/6702

May 6, 2024

Member

jvega190 commented Apr 30, 2024

craftercms/craftercms#6702


          [6702] Image cropper increases size of an image relative to the original

1d10f8d

jvega190 requested a review from rart as a code owner

April 30, 2024 16:52

jvega190 commented

View reviewed changes

static-assets/components/cstudio-dialogs/crop-dialog.js

    
            @@ -363,7 +363,7 @@ CStudioAuthoring.Dialogs.CropDialog = CStudioAuthoring.Dialogs.CropDialog || {
          
                      self = self;

                    const canvas = $image.cropper('getCroppedCanvas');

                    var dataUrl = canvas.toDataURL();

                    const dataUrl = canvas.toDataURL(imageData.meta.type);

Member Author

jvega190 Apr 30, 2024

Default type value for toDataURL is image/png, causing the size of jpg images to be bigger than the original

rart approved these changes

View reviewed changes

sumerjabri merged commit 05393a7 into craftercms:develop

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment