Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cluster.rst - added generic thread pool definition #15690

Merged
merged 3 commits into from Mar 15, 2024

Conversation

karynzv
Copy link
Contributor

@karynzv karynzv commented Mar 13, 2024

Summary of the changes / Why this improves CrateDB

Added the description of generic thread pool to the thread pools subsection

Checklist

  • Added an entry in the latest docs/appendices/release-notes/<x.y.0>.rst for user facing changes
  • Updated documentation & sql_features table for user facing changes
  • Touched code is covered by tests
  • CLA is signed
  • This does not contain breaking changes, or if it does:
    • It is released within a major release
    • It is recorded in the latest docs/appendices/release-notes/<x.y.0>.rst
    • It was marked as deprecated in an earlier release if possible
    • You've thought about the consequences and other components are adapted
      (E.g. AdminUI)

docs/config/cluster.rst Outdated Show resolved Hide resolved
@mfussenegger mfussenegger changed the base branch from 5.6 to master March 13, 2024 15:44
@mfussenegger
Copy link
Member

Thanks for the PR. I changed the generic definition slightly, changed the target branch to master (please always make PRs against master, unless the change is really only specific to a older release and it's already fixed in master), and also added another commit to elaborate more on when tuning the size might make sense and when it doesn't

@romseygeek @matriv and @seut please have another look.

@mfussenegger
Copy link
Member

Looks like vale failure is a false positive (detecting to touch as to to repetition), doesn't happen with my locale vale so I'll look into updating the vale version on CI

@mfussenegger
Copy link
Member

I'll look into updating the vale version on CI

Actually, would be nice if somebody could take this over. Otherwise this will have to wait until next week

@matriv
Copy link
Contributor

matriv commented Mar 14, 2024

I've amended the second commit with some minor changes (like adding link for refresh), some commas, etc. @seut Can you please take a look before we merge it?

Update: also updated vale in a new commit, seems to work now.

@matriv matriv added the v/5.6 label Mar 14, 2024
Copy link
Member

@seut seut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

@matriv matriv merged commit aff1c9e into master Mar 15, 2024
12 checks passed
@matriv matriv deleted the karynzv-thread-pools branch March 15, 2024 15:23
@matriv
Copy link
Contributor

matriv commented Mar 15, 2024

@Mergifyio backport 5.6

Copy link

mergify bot commented Mar 15, 2024

backport 5.6

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants