New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cluster.rst - added generic thread pool definition #15690
Conversation
b7f3bc8
to
c14a39f
Compare
Thanks for the PR. I changed the generic definition slightly, changed the target branch to master (please always make PRs against master, unless the change is really only specific to a older release and it's already fixed in master), and also added another commit to elaborate more on when tuning the size might make sense and when it doesn't @romseygeek @matriv and @seut please have another look. |
Looks like vale failure is a false positive (detecting |
Actually, would be nice if somebody could take this over. Otherwise this will have to wait until next week |
c150be2
to
a8001e9
Compare
I've amended the second commit with some minor changes (like adding link for Update: also updated vale in a new commit, seems to work now. |
fa1d309
to
9a478ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks!
@Mergifyio backport 5.6 |
✅ Backports have been created
|
Summary of the changes / Why this improves CrateDB
Added the description of generic thread pool to the thread pools subsection
Checklist
docs/appendices/release-notes/<x.y.0>.rst
for user facing changessql_features
table for user facing changesdocs/appendices/release-notes/<x.y.0>.rst
(E.g. AdminUI)