Fix coglin weirdness with cursed weapons #3704
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would probably be better to split can_unwield from can_wield, but I don't want to touch this more than I need to. The code about trying to equip a two handed weapon as a coglin with cursed weapons is unnecessary because you are already asked to remove your off-hand weapon first even if neither is cursed and I don't think anyone actually wants to use a two handed weapon as a coglin. Fixes crawl#3562.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would probably be better to split can_unwield from can_wield, but I don't want to touch this more than I need to.
The code about trying to equip a two handed weapon as a coglin with cursed weapons is unnecessary because you are already asked to remove your off-hand weapon first even if neither is cursed and I don't think anyone actually wants to use a two handed weapon as a coglin.
Fixes #3562.