Improve the A screen for forms #3749
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
For the longest time (likely forever), forms' innate resistances
have not been displayed on the A screen with the rest of the form
properties, except for poison immunity and torment resistance
(which are weirdly specific exceptions). This commit changes that.
Resistances will only be displayed where the player doesn't have a
(non-suppressed) mutation superseding them.
Add the blinkbolt and siphon essence abilities, clarify shadow form's
spellcasting penalty and resists, add descriptions of bad forms'
offensive and defensive stats, clarify wisp form's "highly resistant"
fakemut and add insubstantial, add serpent form's cold-bloodedness,
split statue form's slowness and melee bonus, display blade hands'
body armour AC penalty, align bat/pig form fast with the mutation.
Also, tone down the wording on alive Vp's regen ("accelerated" sounds
faster than "unusually fast" to me, even though the effect is 1/4 of
"unusually fast").
Add a new `badmuts` field to form-data.h, so that all of the red-
coloured "bad" fakemuts can be displayed on A together, and to remove
hacky and inconsistent <lightred> tags in form-data.h. Reclassify
some existing fakemuts as bad (e.g. tree stationary, statue slow).
Fix bugs with amphibiousness not displaying in permanent forms and
poison immunity displaying as an innate fakemut instead of a form
fakemut for some forms, which were caused by the addition of
permanent forms in 0.31. Fix fungus form having rN+++ even though
plants and wandering mushrooms no longer have this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the longest time (likely forever), forms' innate resistances have not been displayed on the A screen with the rest of the form properties, except for poison immunity and torment resistance (which are weirdly specific exceptions). This PR changes that. Resistances will only be displayed where the player doesn't have a (non-suppressed) mutation superseding them.
Add the blinkbolt and siphon essence abilities, clarify shadow form's spellcasting penalty, add descriptions of bad forms' offensive and defensive stats, clarify wisp form's "highly resistant" fakemut, add serpent form's cold-bloodedness, split statue form's slowness and melee bonus, display blade hands' body armour AC penalty, tone down the wording on alive Vp's regen ("accelerated" sounds faster than "unusually fast" to me, even though the effect is 1/4 of "unusually fast").
Add a new
badmutsfield to form-data.h, so that all of the red- coloured "bad" fakemuts can be displayed on A together, and to remove hacky and inconsistent tags in form-data.h. Reclassify some existing fakemuts as bad (e.g. tree stationary, statue slow, flux glow).Fix bugs with amphibiousness not displaying in permanent forms and poison immunity displaying as an innate fakemut instead of a form fakemut for some forms, which were caused by the addition of permanent forms in 0.31.
I haven't touched the A! "form properties" screen at all with this PR. That screen is in a troubled place, in that it's really "talisman properties" and copies the talisman description, it doesn't display if you didn't enter a form via a talisman, and it's rather obscure (I imagine many players have never noticed it...) This is on my list of things to look at in a different PR.
A few pictures below show some of the changes.