Renamed "coowner" to "collaborator". To be reviewed once the role def…

…initions are refactored and consolidated in a single place

cmd/reva/common.go

@@ -33,7 +33,7 @@ const (
 	viewerPermission  string = "viewer"
 	readerPermission  string = "reader"
 	editorPermission  string = "editor"
-	coownerPermission string = "coowner"
+	collabPermission  string = "collab"
 	denyPermission    string = "denied"
 )
 

cmd/reva/share-create.go

@@ -181,7 +181,7 @@ func getSharePerm(p string) (*provider.ResourcePermissions, error) {
 			RestoreFileVersion:   true,
 			Move:                 true,
 		}, nil
-	case coownerPermission:
+	case collabPermission:
 		return &provider.ResourcePermissions{
 			GetPath:              true,
 			InitiateFileDownload: true,

internal/http/services/owncloud/ocs/conversions/role.go

@@ -40,14 +40,16 @@ const (
 	RoleLegacy string = "legacy"
 	// RoleDenied grants no permission at all on a resource
 	RoleDenied string = "denied"
-	// RoleViewer grants non-editor role on a resource
+	// RoleViewer grants a view-only role (no download) on a resource
 	RoleViewer string = "viewer"
-	// RoleEditor grants editor permission on a resource, including folders
+	// RoleReader grants non-editor role on a resource
+        RoleReader string = "reader"
+        // RoleEditor grants editor permission on a resource, including folders
 	RoleEditor string = "editor"
 	// RoleFileEditor grants editor permission on a single file
 	RoleFileEditor string = "file-editor"
-	// RoleCoowner grants owner permissions on a resource
-	RoleCoowner string = "coowner"
+	// RoleCollaborator rgrants editor+resharing permissions on a resource
+	RoleCollaborator string = "collaborator"
 	// RoleUploader FIXME: uploader role with only write permission can use InitiateFileUpload, not anything else
 	RoleUploader string = "uploader"
 )