Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading gherkin parser according language comment #116

Closed
wants to merge 2 commits into from
Closed

Loading gherkin parser according language comment #116

wants to merge 2 commits into from

Conversation

bclozel
Copy link

@bclozel bclozel commented Mar 27, 2013

Hello there.

This issue could be seen as a duplicate of #109 but @vslinko stopped working on this - I'm willing to give it a try.

I've been working on the same problems @vslinko faced in issue #109 : a lexing error when parsing the first non-comment line (exactly, when parsing the first keyword).
Tests and specs run ok this time - but I've stumbled on the same problems with the non-en parsers.

When debugging this issue, it seemed that valid data was passed to the non-en parser. I'm wondering if it's a parser issue or an encoding issue on our part.

Could you give me directions:

  • how could I dig deeper into this?
  • how could I create a sample testcase to check if this problem is on gherkin's/cucumber-js's side?
  • should I request support on the mailing list?

Some details about this PR:

  • works only if the "# language" meta is on the first line
  • does a "featureSource.toString", which is not optimal for nodejs implementation (since we're converting the buffer to a plain string)
  • this code should be modified in the future if we want to support other meta comments like "# encoding"

@ldegen ldegen mentioned this pull request Jan 13, 2014
Closed
@ldegen ldegen mentioned this pull request Feb 21, 2014
@jbpros jbpros closed this in 9ace841 Mar 5, 2014
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant