Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/fix remaining cops #158

Merged
merged 6 commits into from May 23, 2024
Merged

Refactor/fix remaining cops #158

merged 6 commits into from May 23, 2024

Conversation

luke-hill
Copy link
Contributor

@luke-hill luke-hill commented Feb 22, 2024

🤔 What's changed?

Partially fix up rubocop offenses - begin to reduce complexity of long methods

⚡️ What's your motivation?

Better code

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@luke-hill luke-hill merged commit aaa4ce4 into main May 23, 2024
28 checks passed
@luke-hill luke-hill deleted the refactor/fix_remaining_cops branch May 23, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant