share_init: fix OOM crash

A failed calloc() would lead to NULL pointer use. Coverity CID 1299427.
curl · May 22, 2015 · 03e2a9b · 03e2a9b
1 parent 817323e
commit 03e2a9b
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/lib/share.c b/lib/share.c
@@ -35,12 +35,13 @@ CURLSH *
 curl_share_init(void)
 {
   struct Curl_share *share = calloc(1, sizeof(struct Curl_share));
-  if(share)
+  if(share) {
     share->specifier |= (1<<CURL_LOCK_DATA_SHARE);
 
-  if(Curl_mk_dnscache(&share->hostcache)) {
-    free(share);
-    return NULL;
+    if(Curl_mk_dnscache(&share->hostcache)) {
+      free(share);
+      return NULL;
+    }
   }
 
   return share;