Skip to content

Commit

Permalink
revert Python SDK changes for now
Browse files Browse the repository at this point in the history
looks like there's more to figure out with module dependencies? either
way, don't want this to block the current PR, they can be re-introduced
in another PR like the other SDKs

Revert "Pin python requirements"

This reverts commit b40c411.

Revert "Add Python support"

This reverts commit 08aa92c.

Signed-off-by: Alex Suraci <alex@dagger.io>
  • Loading branch information
vito committed Apr 2, 2024
1 parent b40c411 commit ff205b5
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 102 deletions.
2 changes: 0 additions & 2 deletions sdk/python/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ dependencies = [
"platformdirs>=2.6.2",
"typing_extensions>=4.8.0",
"rich>=10.11.0",
"opentelemetry-sdk>=1.23.0",
"opentelemetry-exporter-otlp-proto-grpc>=1.23.0",
]

[project.urls]
Expand Down
34 changes: 0 additions & 34 deletions sdk/python/requirements/proj.txt
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,9 @@ certifi==2024.2.2
# via
# httpcore
# httpx
deprecated==1.2.14
# via
# opentelemetry-api
# opentelemetry-exporter-otlp-proto-grpc
googleapis-common-protos==1.63.0
# via opentelemetry-exporter-otlp-proto-grpc
gql==3.5.0
graphql-core==3.2.3
# via gql
grpcio==1.62.1
# via opentelemetry-exporter-otlp-proto-grpc
h11==0.14.0
# via httpcore
httpcore==1.0.4
Expand All @@ -36,34 +28,13 @@ idna==3.6
# anyio
# httpx
# yarl
importlib-metadata==7.0.0
# via opentelemetry-api
markdown-it-py==3.0.0
# via rich
mdurl==0.1.2
# via markdown-it-py
multidict==6.0.5
# via yarl
opentelemetry-api==1.24.0
# via
# opentelemetry-exporter-otlp-proto-grpc
# opentelemetry-sdk
opentelemetry-exporter-otlp-proto-common==1.24.0
# via opentelemetry-exporter-otlp-proto-grpc
opentelemetry-exporter-otlp-proto-grpc==1.24.0
opentelemetry-proto==1.24.0
# via
# opentelemetry-exporter-otlp-proto-common
# opentelemetry-exporter-otlp-proto-grpc
opentelemetry-sdk==1.24.0
# via opentelemetry-exporter-otlp-proto-grpc
opentelemetry-semantic-conventions==0.45b0
# via opentelemetry-sdk
platformdirs==4.2.0
protobuf==4.25.3
# via
# googleapis-common-protos
# opentelemetry-proto
pygments==2.17.2
# via rich
rich==13.7.1
Expand All @@ -72,10 +43,5 @@ sniffio==1.3.1
# anyio
# httpx
typing-extensions==4.10.0
# via opentelemetry-sdk
wrapt==1.16.0
# via deprecated
yarl==1.9.4
# via gql
zipp==3.18.1
# via importlib-metadata
60 changes: 0 additions & 60 deletions sdk/python/src/dagger/client/_otel.py

This file was deleted.

6 changes: 0 additions & 6 deletions sdk/python/src/dagger/client/_session.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
from dagger import ClientConnectionError
from dagger._config import ConnectConfig, Retry
from dagger._managers import ResourceManager
from dagger.client import _otel as otel

logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -65,7 +64,6 @@ def __init__(self, conn: ConnectParams, cfg: ConnectConfig | None = None):

transport = HTTPXAsyncTransport(
conn.url,
transport=otel.AsyncTransport(),
timeout=cfg.timeout,
auth=(conn.session_token, ""),
)
Expand All @@ -90,10 +88,6 @@ async def start(self) -> AsyncClientSession:

async with self.get_stack() as stack:
logger.debug("Establishing client session to GraphQL server")

await stack.enter_async_context(
otel.start_as_current_span("GraphQL client session"),
)
try:
session = await stack.enter_async_context(self.client)
except TimeoutError as e:
Expand Down

0 comments on commit ff205b5

Please sign in to comment.