fix: change go module name to match dagger module name #6774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedevc
force-pushed
the
switch-to-dagger-module-name
branch
from
598dcaf
to
2523093
Compare
jedevc
force-pushed
the
switch-to-dagger-module-name
branch
from
2523093
to
5b2f80e
Compare
vito
approved these changes
Mar 4, 2024
TomChv
reviewed
Mar 4, 2024
This effectively reverts 7760080, since with go.work support we can't have duplicate module names inside a single namespace. Thankfully though, we can avoid the original issue that this fixed (where `go` is effectively a reserved module name), by prefixing all module names with `dagger/`). Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
Signed-off-by: Justin Chadwell <me@jedevc.com>
jedevc
force-pushed
the
switch-to-dagger-module-name
branch
from
5b2f80e
to
73b692c
Compare
No, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This effectively reverts #5983, since with go.work support we can't have duplicate module names inside a single namespace.
Thankfully though, we can avoid the original issue that this fixed (where
gois effectively a reserved module name), by prefixing all module names withdagger/).This helps for daggerverse-like repo structures, where the top-level
go.workwould ideally need to contain all the sub-modules.