-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from Progrock to OpenTelemetry #6835
Commits on Mar 6, 2024
-
* All Progrock plumbing is now gone, though we may want to bring it back for compatibility. Removing it was a useful exercise to find the many places where we're relying on it. * TUI now supports -v, -vv, -vvv (configurable verbosity). Global flags like --debug, -v, --silent, etc. are processed anywhere in the command string and respected. * CLI forwards engine traces and logs to configured exporters, no need to configure engine-side (we already need this flow for the TUI) * "Live" spans are emitted to TUI and cloud, filtered out before sending to a traditional (non-Live) otel stack * Engine supports pub/sub for traces and logs, can be exposed in the future as a GraphQL subscription * Refactor context.Background usage to context.WithoutCancel. We usually don't want a total reset, since that drops the span context and any other telemetry related things (loggers etc). Go 1.21 added context.WithoutCancel which is more precise. * engine: don't include source in slogs. Added this prospectively and it doesn't seem worth the noise. * idtui: DB can record multiple traces, polish * multi traces is mostly for dagviz, so i can run it with a single DB * add 'passthrough' UI flag which tells the UI to ignore a span and descend into its children * add 'ignore' UI flag, to be used sparingly for things whose signal:noise ratio is irredeemibly low (e.g. 'id' calls) * make loadFooFromID calls passthrough * make Buildkit gRPC calls passthrough * Global Progrock rogs are theoretically replaced with tracing.GlobalLogger, but it has yet to be integrated into anything. * Module functions are pure after all. They're already cached per-session, so this makes DagQL reflect that, avoiding duplicate Buildkit work that would be deduped at the Buildkit layer. Cleans up the telemetry since previously you'd see duplicate queries. * TODO: ensure draining is airtight * TODO: global logging to TUI * TODO: batch forwarded engine spans instead of emitting them "live" * TODO: fix dagger terminal Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 9aefcf2 - Browse repository at this point
Copy the full SHA 9aefcf2View commit details -
Merge remote-tracking branch 'upstream/main' into otel-tui
Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for abde5d4 - Browse repository at this point
Copy the full SHA abde5d4View commit details
Commits on Mar 7, 2024
-
previously we would cancel all subscribers for a trace whenever a client/derver went away. but for modules/nesting this meant the inner call would cancel the whole trace early. * TODO: looks like services still don't drain completely? Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for e0b39b0 - Browse repository at this point
Copy the full SHA e0b39b0View commit details -
don't set up logs if not configured
Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 2899340 - Browse repository at this point
Copy the full SHA 2899340View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b8c0fd - Browse repository at this point
Copy the full SHA 2b8c0fdView commit details -
clean up shim early tracing remnants
Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for b7c921b - Browse repository at this point
Copy the full SHA b7c921bView commit details -
synchronously detach services on main client exit
previously service spans would be left incomplete on exit. now we'll detach from them on shutdown, which will only stop the service if we're the last depender on it. end result _should_ be that services are always completed through telemetry, but I've seen maybe 2 in 50 runs still leave it running. still troubleshooting, but without this change there is no hope at all. fixes dagger#6493 Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for bf34d84 - Browse repository at this point
Copy the full SHA bf34d84View commit details -
flush telemetry before closing server clients
Honestly not 100% confirmed, but seems right. I think the final solution might be to get traces/logs out without going through a session in the first place. Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 4036ce0 - Browse repository at this point
Copy the full SHA 4036ce0View commit details -
switch from errgroup to conc for panic handling
seeing a panic in ExportSpans/UploadTraces, this should help avoid bringing whole server down - I think - or at least give us hope. Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for b3fe350 - Browse repository at this point
Copy the full SHA b3fe350View commit details -
nest 'starting session' beneath 'connect'
Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 29e82ee - Browse repository at this point
Copy the full SHA 29e82eeView commit details -
send logs out from engine to log exporter too
Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 0f856e4 - Browse repository at this point
Copy the full SHA 0f856e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for c3ad64b - Browse repository at this point
Copy the full SHA c3ad64bView commit details
Commits on Mar 9, 2024
-
switch to server-side telemetry pub/sub
fetching the logs/traces over a session is really annoying with draining because the session itself gets closed before things can be fully flushed. Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for e7b370d - Browse repository at this point
Copy the full SHA e7b370dView commit details -
Merge remote-tracking branch 'upstream/main' into otel-tui
Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 008fae1 - Browse repository at this point
Copy the full SHA 008fae1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 79008a0 - Browse repository at this point
Copy the full SHA 79008a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for a62f251 - Browse repository at this point
Copy the full SHA a62f251View commit details -
send individual Calls over telemetry instead of IDs
More than a 10x efficiency increase. Frontend still super easy to implement. Test: # in ~/src/bass $ with-dev dagger call -m ./ --src https://github.com/vito/bass unit --packages ./pkg/cli stdout --debug &> out $ rg measuring out | cut -d= -f2 | xargs | tr ' ' '+' | sed -e 's/0m//g' -e 's/[^0-9\+]//g' | cat -v | bc Before: 8524838 (~8.1 MiB) After: 727039 (~0.7 MiB) Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 0c3e216 - Browse repository at this point
Copy the full SHA 0c3e216View commit details -
idtui Base was correct in returning bool
Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 641e3a6 - Browse repository at this point
Copy the full SHA 641e3a6View commit details -
handle case where calls haven't been seen yet
kinda hacky, but it makes sense that we need to handle this, cause loadFooFromID or generally anything can take an ID that's never been seen by the server before, and the loadFooFromID span will come first. Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 0f2ea03 - Browse repository at this point
Copy the full SHA 0f2ea03View commit details -
idtui: add space between progress and primary output
Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 91c9192 - Browse repository at this point
Copy the full SHA 91c9192View commit details -
swap -vvv and -vv, -vv now breaks encapsulation
Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 7cd1bf6 - Browse repository at this point
Copy the full SHA 7cd1bf6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2399d94 - Browse repository at this point
Copy the full SHA 2399d94View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5219fb2 - Browse repository at this point
Copy the full SHA 5219fb2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fbfd9c - Browse repository at this point
Copy the full SHA 0fbfd9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for fd6b22e - Browse repository at this point
Copy the full SHA fd6b22eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 152f767 - Browse repository at this point
Copy the full SHA 152f767View commit details -
Configuration menu - View commit details
-
Copy full SHA for 322df5f - Browse repository at this point
Copy the full SHA 322df5fView commit details
Commits on Mar 10, 2024
-
nuclear option: wait for all spans to complete
Rather than closing the telemetry connection and hoping the timing works out, we keep track of which traces have active spans and wait for that count to reach 0. A bit more complicated but not seeing a simpler solution really. Without this we can't ensure that the client sees the very outermost spans complete. Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 7070093 - Browse repository at this point
Copy the full SHA 7070093View commit details -
hasn't really been useful, it's available in the full trace for devs, or we can add a verbosity level. Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for a34d10f - Browse repository at this point
Copy the full SHA a34d10fView commit details -
dagviz: tweaks to support visualizing a live trace
Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for c812028 - Browse repository at this point
Copy the full SHA c812028View commit details
Commits on Mar 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8882ef5 - Browse repository at this point
Copy the full SHA 8882ef5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a508fb - Browse repository at this point
Copy the full SHA 1a508fbView commit details
Commits on Mar 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f607ce4 - Browse repository at this point
Copy the full SHA f607ce4View commit details -
pass auth headers to OTLP logs too
Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 2bab220 - Browse repository at this point
Copy the full SHA 2bab220View commit details -
fix stdio not making it out of gateway containers
Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for a7f4b46 - Browse repository at this point
Copy the full SHA a7f4b46View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e07c62 - Browse repository at this point
Copy the full SHA 5e07c62View commit details -
drain immediately when interrupted
otherwise we can get stuck waiting for child spans of a nested process that got kill -9'd. not perfect but better than hanging on Ctrl+C which is already an emergent situation where you're not likely that interested in any remaining data if you already had a reason to interrupt. in Cloud we'll clean up any orphaned spans based on keepalives anyway. Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 8c90f2a - Browse repository at this point
Copy the full SHA 8c90f2aView commit details -
fix unintentionally HTTP-ifying gRPC otlp enpoint
Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for ed31975 - Browse repository at this point
Copy the full SHA ed31975View commit details -
give up retrying connection if outer ctx canceled
Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for f31846d - Browse repository at this point
Copy the full SHA f31846dView commit details -
initiate draining only when main client goes away
Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for c4b563a - Browse repository at this point
Copy the full SHA c4b563aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f53f239 - Browse repository at this point
Copy the full SHA f53f239View commit details
Commits on Mar 14, 2024
-
we don't need to try synchronizing here now that we just generically wait for all spans to complete Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for d610561 - Browse repository at this point
Copy the full SHA d610561View commit details -
Configuration menu - View commit details
-
Copy full SHA for a1c442a - Browse repository at this point
Copy the full SHA a1c442aView commit details -
Configuration menu - View commit details
-
Copy full SHA for cd899de - Browse repository at this point
Copy the full SHA cd899deView commit details -
print final progress tree in plain mode
no substitute for live console streaming, but easier to implement for now, and probably easier to read in CI. probably needs more work, but might get some tests passing. Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 1078f30 - Browse repository at this point
Copy the full SHA 1078f30View commit details -
Configuration menu - View commit details
-
Copy full SHA for 23e3f04 - Browse repository at this point
Copy the full SHA 23e3f04View commit details
Commits on Mar 15, 2024
-
propagate spans through dagger-in-dagger
Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 8e824fc - Browse repository at this point
Copy the full SHA 8e824fcView commit details -
Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for cb4c314 - Browse repository at this point
Copy the full SHA cb4c314View commit details -
propagate span context through dagger run
Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for cd09ab9 - Browse repository at this point
Copy the full SHA cd09ab9View commit details -
install default labels as otel resource attrs
Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 65ab328 - Browse repository at this point
Copy the full SHA 65ab328View commit details -
Configuration menu - View commit details
-
Copy full SHA for 02e57de - Browse repository at this point
Copy the full SHA 02e57deView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2eee30d - Browse repository at this point
Copy the full SHA 2eee30dView commit details -
these are expected to fail now Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for bf366ba - Browse repository at this point
Copy the full SHA bf366baView commit details
Commits on Mar 16, 2024
-
fail root span when command fails
Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 76b3874 - Browse repository at this point
Copy the full SHA 76b3874View commit details
Commits on Mar 18, 2024
-
Container.import: add span for streaming image
Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 2b85aa4 - Browse repository at this point
Copy the full SHA 2b85aa4View commit details -
idtui: break encapsulation in case of errors
Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 45f8ad5 - Browse repository at this point
Copy the full SHA 45f8ad5View commit details -
fix schema-level logging not exporting
caught by TestDaggerUp/random Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 58c50c6 - Browse repository at this point
Copy the full SHA 58c50c6View commit details -
update TestDaggerRun assertion
Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 50baada - Browse repository at this point
Copy the full SHA 50baadaView commit details -
fix test not syncing on progress completion
Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for ae0aea5 - Browse repository at this point
Copy the full SHA ae0aea5View commit details -
Configuration menu - View commit details
-
Copy full SHA for c20d65a - Browse repository at this point
Copy the full SHA c20d65aView commit details -
respect $DAGGER_CLOUD_URL and $DAGGER_CLOUD_TOKEN
promoting these from _EXPERIMENTAL along the way, which has already been done for _TOKEN, don't really see a strong reason to keep the _EXPERIMENTAL prefix, but low conviction Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 97efa54 - Browse repository at this point
Copy the full SHA 97efa54View commit details -
port 'processor: support span keepalive'
originally aluzzardi/otel-in-flight@2fc011f Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 08cf4d3 - Browse repository at this point
Copy the full SHA 08cf4d3View commit details
Commits on Mar 19, 2024
-
really helps with troubleshooting hanging tests! Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 206de8b - Browse repository at this point
Copy the full SHA 206de8bView commit details -
set a reasonable window size in plain mode
otherwise the terminals resize a ton of times when a long string is printed, absolutely tanking performance. would be nice if that were fast, but no time for that now. Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for c630bf1 - Browse repository at this point
Copy the full SHA c630bf1View commit details -
manually revert container.import change
i thought this wouldn't break it, but ... ? Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 33b53d1 - Browse repository at this point
Copy the full SHA 33b53d1View commit details -
Merge remote-tracking branch 'upstream/main' into otel-tui
Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for bf1319f - Browse repository at this point
Copy the full SHA bf1319fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 132e74e - Browse repository at this point
Copy the full SHA 132e74eView commit details -
mark watch command experimental
Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 459ed03 - Browse repository at this point
Copy the full SHA 459ed03View commit details -
Configuration menu - View commit details
-
Copy full SHA for 808a676 - Browse repository at this point
Copy the full SHA 808a676View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d69d1b - Browse repository at this point
Copy the full SHA 4d69d1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f40276 - Browse repository at this point
Copy the full SHA 2f40276View commit details -
really not sure what's writing to stderr even with --silent but this is just too brittle. redirect stderr to /dev/null instead. Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 09f7de7 - Browse repository at this point
Copy the full SHA 09f7de7View commit details -
retire dagger.io/ui.primary, use root span instead
fixes Views test; frontend must have been getting confused because there were multiple "primary" spans Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 125b4c5 - Browse repository at this point
Copy the full SHA 125b4c5View commit details -
take 2: just manually mark the 'primary' span
Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 47ff78c - Browse repository at this point
Copy the full SHA 47ff78cView commit details -
merge tracing and telemetry packages
Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for fb88848 - Browse repository at this point
Copy the full SHA fb88848View commit details -
Configuration menu - View commit details
-
Copy full SHA for d0f12bf - Browse repository at this point
Copy the full SHA d0f12bfView commit details -
this was no longer needed with the change to wait for spans to finish, not worth the review-time distraction Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for c564e89 - Browse repository at this point
Copy the full SHA c564e89View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2447156 - Browse repository at this point
Copy the full SHA 2447156View commit details
Commits on Mar 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c3c429a - Browse repository at this point
Copy the full SHA c3c429aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2705bd4 - Browse repository at this point
Copy the full SHA 2705bd4View commit details -
default primary span to root span
Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 35af790 - Browse repository at this point
Copy the full SHA 35af790View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ca7e73 - Browse repository at this point
Copy the full SHA 1ca7e73View commit details -
send engine traces/logs to cloud
Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 29c1b67 - Browse repository at this point
Copy the full SHA 29c1b67View commit details
Commits on Mar 25, 2024
-
Some clients presume this service is supported by the OTLP endpoint. So we can just have a stub implementation for now. Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 8a055cd - Browse repository at this point
Copy the full SHA 8a055cdView commit details -
sdk/go runtime: implement otel propagation
TODO: set up otel for you Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 65f07f3 - Browse repository at this point
Copy the full SHA 65f07f3View commit details
Commits on Mar 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 93da881 - Browse repository at this point
Copy the full SHA 93da881View commit details
Commits on Mar 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c59a2c2 - Browse repository at this point
Copy the full SHA c59a2c2View commit details -
batch events that are sent from the engine
Previously we were just sending each individual update to the configured exporters, which was very expensive and would even slow down the TUI. When I originally tried to send it to span processors, nothing would be sent out; turns out that was because the transform.Spans call we were using didn't set the `Sampled` trace flag. Now we forward engine traces and logs to all configured processors, so their individual batching settings should be respected. Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for ddd17d1 - Browse repository at this point
Copy the full SHA ddd17d1View commit details -
fix spans being deduped within single batch
* fix detection for in flight spans; we need to check EndTime < StartTime since sometimes we end up with a 1754 timestamp * when a span is already present in a batch, update it in-place rather than dropping it on the floor Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for dbc13df - Browse repository at this point
Copy the full SHA dbc13dfView commit details
Commits on Mar 28, 2024
-
Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 08aa92c - Browse repository at this point
Copy the full SHA 08aa92cView commit details -
shim: proxy otel to 127.0.0.1:0
more universally compatible than unix:// Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for c8b06ff - Browse repository at this point
Copy the full SHA c8b06ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5fc4ecb - Browse repository at this point
Copy the full SHA 5fc4ecbView commit details -
attributes: add passthrough, bikeshed + document
also start cleaning up "tasks" cruft nonsense, these can just be plain old attributes on a single span i think Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 4cc5b56 - Browse repository at this point
Copy the full SHA 4cc5b56View commit details -
parse global flags in two passes, ensuring the same flags are installed in both cases, and capturing the values before installing them into the real flag set, since that clobbers the values Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for d95d664 - Browse repository at this point
Copy the full SHA d95d664View commit details
Commits on Mar 29, 2024
-
...just in case it gets buffered in memory forever otherwise Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for cbffddc - Browse repository at this point
Copy the full SHA cbffddcView commit details -
sdk/go: somewhat gross support for opentelemetry
had to copy-paste a lot of the telemetry code into sdk/go/. would love to just move everything there so it can be shared between the shim, the Go runtime, and the engine, however it is currently a huge PITA to share code between all three, because of the way codegen works. saving that for another day. maybe tomorrow. Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 31b303b - Browse repository at this point
Copy the full SHA 31b303bView commit details -
send logs to function call span, not exec /runtime
Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 64a98a9 - Browse repository at this point
Copy the full SHA 64a98a9View commit details -
tui: respect dagger.io/ui.mask
no more exec /runtime! Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for b161258 - Browse repository at this point
Copy the full SHA b161258View commit details -
worth refactoring, but not now™ Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for a8fec0d - Browse repository at this point
Copy the full SHA a8fec0dView commit details
Commits on Apr 2, 2024
-
ignore --help when parsing global flags
Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for dce8443 - Browse repository at this point
Copy the full SHA dce8443View commit details -
Signed-off-by: Helder Correia <174525+helderco@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for b40c411 - Browse repository at this point
Copy the full SHA b40c411View commit details -
revert Python SDK changes for now
looks like there's more to figure out with module dependencies? either way, don't want this to block the current PR, they can be re-introduced in another PR like the other SDKs Revert "Pin python requirements" This reverts commit b40c411. Revert "Add Python support" This reverts commit 08aa92c. Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for ff205b5 - Browse repository at this point
Copy the full SHA ff205b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1216ae8 - Browse repository at this point
Copy the full SHA 1216ae8View commit details -
fix race conditions in python SDK runtime
Signed-off-by: Alex Suraci <alex@dagger.io>
Configuration menu - View commit details
-
Copy full SHA for 17d17f2 - Browse repository at this point
Copy the full SHA 17d17f2View commit details