fix file and cmd secret source inputs #6845
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported here: #6829 (comment)
Based on my testing, the following did not work:
Breaking out the file parsing code, the
token.txt
would be parsed with a newline character at the end.This adds
TrimSpace()
to file and cmd secret inputs.TrimSpace()
trims leading and trailing unicode whitespace characters. I can't think of any cases where this would have unintended consequences for secrets.