fix: prevent variable shadow in TestModuleDaggerDevelop #6926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This manifested as additional flakiness in the test, causing `out` to be written to in a racey way: WARNING: DATA RACE Write at 0x00c00189a6c0 by goroutine 20341: github.com/dagger/dagger/core/integration.TestModuleDaggerDevelop.func1.1() /app/core/integration/module_config_test.go:542 +0x9bd testing.tRunner() /usr/local/go/src/testing/testing.go:1595 +0x261 testing.(*T).Run.func1() /usr/local/go/src/testing/testing.go:1648 +0x44 Previous write at 0x00c00189a6c0 by goroutine 20342: github.com/dagger/dagger/core/integration.TestModuleDaggerDevelop.func1.1() /app/core/integration/module_config_test.go:542 +0x9bd testing.tRunner() /usr/local/go/src/testing/testing.go:1595 +0x261 testing.(*T).Run.func1() /usr/local/go/src/testing/testing.go:1648 +0x44 Signed-off-by: Justin Chadwell <me@jedevc.com>
jedevc
commented
Mar 25, 2024
| @@ -539,7 +539,7 @@ func TestModuleDaggerDevelop(t *testing.T) { | |||
| }) | |||
|
|
|||
| // should be able to invoke it directly now | |||
| out, err = ctr.With(daggerCall("fn")).Stdout(ctx) | |||
| out, err := ctr.With(daggerCall("fn")).Stdout(ctx) | |||
There was a problem hiding this comment.
love a good one line fix 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in #6860, causing some additional test flake.
This manifested as additional flakiness in the test, causing
outto be written to in a racey way: