Skip to content
This repository has been archived by the owner on Apr 17, 2018. It is now read-only.

Commit

Permalink
[do_postgres] Revert "Added proper typecasting for doubles passed as …
Browse files Browse the repository at this point in the history
…string"

* Coersion should take place at a DataMapper-level. I don't yet
  understand the use-case for this at a DataObjects-level.

This reverts commit a5f5c83.

Conflicts:

	do_sqlite3/spec/spec_helper.rb

[#1142 state:hold]

Signed-off-by: Alex Coles <alex@alexcolesportfolio.com>
  • Loading branch information
myabc committed Dec 24, 2009
1 parent f487367 commit 8ba8403
Showing 1 changed file with 0 additions and 16 deletions.
Expand Up @@ -79,27 +79,11 @@ public void setPreparedStatementParam(PreparedStatement ps,
case STRING:
jdbcType = ps.getParameterMetaData().getParameterType(idx);
switch (jdbcType) {
// TODO
// May be added in the future for optimization (String parameter -> String column)
// in case we will have many 'cases' here
// case Types.VARCHAR:
// ps.setString(idx, arg.toString());
// break;
case Types.INTEGER:
// conversion for '.execute_reader("2")'
ps.setInt(idx, Integer.valueOf(arg.toString()));
break;
case Types.FLOAT:
// conversion for '.execute_reader("2.1")'
ps.setFloat(idx, Float.valueOf(arg.toString()));
break;
case Types.DOUBLE:
// conversion for '.execute_reader("2.1")'
ps.setDouble(idx, Double.valueOf(arg.toString()));
break;
default:
// String parameter -> {String, other type} column
// XXX Please look at line #82
ps.setString(idx, arg.toString());
}
break;
Expand Down

0 comments on commit 8ba8403

Please sign in to comment.