[do_postgres][do_sqlite3] Added proper typecasting for doubles passed…

… as string * Added proper typecasting for doubles passed as string * Fixed typo in sqlite3's spec helper
datamapper · Dec 6, 2009 · a5f5c83 · a5f5c83
1 parent 55b3dc3
commit a5f5c83
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/do_postgres/ext-java/src/main/java/do_postgres/PostgresDriverDefinition.java b/do_postgres/ext-java/src/main/java/do_postgres/PostgresDriverDefinition.java
@@ -79,11 +79,27 @@ public void setPreparedStatementParam(PreparedStatement ps,
         case STRING:
             jdbcType = ps.getParameterMetaData().getParameterType(idx);
             switch (jdbcType) {
+            //  TODO
+            //  May be added in the future for optimization (String parameter -> String column)
+            //  in case we will have many 'cases' here
+            //  case Types.VARCHAR:
+            //  ps.setString(idx, arg.toString());
+            //  break;
             case Types.INTEGER:
                 // conversion for '.execute_reader("2")'
                 ps.setInt(idx, Integer.valueOf(arg.toString()));
                 break;
+            case Types.FLOAT:
+                // conversion for '.execute_reader("2.1")'
+                ps.setFloat(idx, Float.valueOf(arg.toString()));
+                break;
+            case Types.DOUBLE:
+                // conversion for '.execute_reader("2.1")'
+                ps.setDouble(idx, Double.valueOf(arg.toString()));
+                break;
             default:
+                // String parameter -> {String, other type} column
+                // XXX Please look at line #82
                 ps.setString(idx, arg.toString());
             }
             break;

diff --git a/do_sqlite3/spec/spec_helper.rb b/do_sqlite3/spec/spec_helper.rb
@@ -44,7 +44,7 @@
 
 CONFIG.uri = ENV["DO_SQLITE3_SPEC_URI"] || "#{CONFIG.scheme}://#{CONFIG.database}"
 CONFIG.jdbc_driver = 'org.sqlite.JDBC'
-CONFIG.jdbc_uri = CONFIG.uri.sub(/postgres/,"jdbc:postgresql")
+CONFIG.jdbc_uri = CONFIG.uri.sub(/sqlite3/,"jdbc:sqlite3")
 
 module DataObjectsSpecHelpers