Skip to content

Commit

Permalink
[Fixes #2529136] - Fixed issue with IE9 beta not reporting e.button p…
Browse files Browse the repository at this point in the history
…roperly
  • Loading branch information
davglass committed Sep 20, 2010
1 parent 9dbd771 commit 0179a9e
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 9 deletions.
7 changes: 5 additions & 2 deletions build/dragdrop/dragdrop-debug.js 100755 → 100644
Expand Up @@ -827,8 +827,8 @@ YAHOO.util.DragDropMgr = function() {
// var button = e.which || e.button;
// YAHOO.log("which: " + e.which + ", button: "+ e.button);

// check for IE mouseup outside of page boundary
if (YAHOO.util.Event.isIE && !e.button) {
// check for IE < 9 mouseup outside of page boundary
if ((YAHOO.util.Event.isIE < 9) && !e.button) {
YAHOO.log("button failure", "info", "DragDropMgr");
this.stopEvent(e);
return this.handleMouseUp(e);
Expand Down Expand Up @@ -2985,6 +2985,7 @@ YAHOO.augment(YAHOO.util.DragDrop, YAHOO.util.EventProvider);
* mouse cursor during a drag.
* @class DD
* @extends YAHOO.util.DragDrop
* @namespace YAHOO.util
* @constructor
* @param {String} id the id of the linked element
* @param {String} sGroup the group of related DragDrop items
Expand Down Expand Up @@ -3361,6 +3362,7 @@ YAHOO.extend(YAHOO.util.DD, YAHOO.util.DragDrop, {
*
* @class DDProxy
* @extends YAHOO.util.DD
* @namespace YAHOO.util
* @constructor
* @param {String} id the id of the linked html element
* @param {String} sGroup the group of related DragDrop objects
Expand Down Expand Up @@ -3681,6 +3683,7 @@ YAHOO.extend(YAHOO.util.DDProxy, YAHOO.util.DD, {
* event listener and the callbacks.
* @class DDTarget
* @extends YAHOO.util.DragDrop
* @namespace YAHOO.util
* @constructor
* @param {String} id the id of the element that is a drop target
* @param {String} sGroup the group of related DragDrop objects
Expand Down
2 changes: 1 addition & 1 deletion build/dragdrop/dragdrop-min.js 100755 → 100644

Large diffs are not rendered by default.

7 changes: 5 additions & 2 deletions build/dragdrop/dragdrop.js 100755 → 100644
Expand Up @@ -811,8 +811,8 @@ YAHOO.util.DragDropMgr = function() {

// var button = e.which || e.button;

// check for IE mouseup outside of page boundary
if (YAHOO.util.Event.isIE && !e.button) {
// check for IE < 9 mouseup outside of page boundary
if ((YAHOO.util.Event.isIE < 9) && !e.button) {
this.stopEvent(e);
return this.handleMouseUp(e);
} else {
Expand Down Expand Up @@ -2896,6 +2896,7 @@ YAHOO.augment(YAHOO.util.DragDrop, YAHOO.util.EventProvider);
* mouse cursor during a drag.
* @class DD
* @extends YAHOO.util.DragDrop
* @namespace YAHOO.util
* @constructor
* @param {String} id the id of the linked element
* @param {String} sGroup the group of related DragDrop items
Expand Down Expand Up @@ -3258,6 +3259,7 @@ YAHOO.extend(YAHOO.util.DD, YAHOO.util.DragDrop, {
*
* @class DDProxy
* @extends YAHOO.util.DD
* @namespace YAHOO.util
* @constructor
* @param {String} id the id of the linked html element
* @param {String} sGroup the group of related DragDrop objects
Expand Down Expand Up @@ -3572,6 +3574,7 @@ YAHOO.extend(YAHOO.util.DDProxy, YAHOO.util.DD, {
* event listener and the callbacks.
* @class DDTarget
* @extends YAHOO.util.DragDrop
* @namespace YAHOO.util
* @constructor
* @param {String} id the id of the element that is a drop target
* @param {String} sGroup the group of related DragDrop objects
Expand Down
4 changes: 2 additions & 2 deletions sandbox/dragdrop/js/DragDropMgr.js
Expand Up @@ -827,8 +827,8 @@ YAHOO.util.DragDropMgr = function() {
// var button = e.which || e.button;
// YAHOO.log("which: " + e.which + ", button: "+ e.button);

// check for IE mouseup outside of page boundary
if (YAHOO.util.Event.isIE && !e.button) {
// check for IE < 9 mouseup outside of page boundary
if ((YAHOO.util.Event.isIE < 9) && !e.button) {
YAHOO.log("button failure", "info", "DragDropMgr");
this.stopEvent(e);
return this.handleMouseUp(e);
Expand Down
4 changes: 2 additions & 2 deletions src/dragdrop/js/DragDropMgr.js
Expand Up @@ -827,8 +827,8 @@ YAHOO.util.DragDropMgr = function() {
// var button = e.which || e.button;
// YAHOO.log("which: " + e.which + ", button: "+ e.button);

// check for IE mouseup outside of page boundary
if (YAHOO.util.Event.isIE && !e.button) {
// check for IE < 9 mouseup outside of page boundary
if ((YAHOO.util.Event.isIE < 9) && !e.button) {
YAHOO.log("button failure", "info", "DragDropMgr");
this.stopEvent(e);
return this.handleMouseUp(e);
Expand Down

0 comments on commit 0179a9e

Please sign in to comment.