Don't raise an exception on JavaScript warnings

davisp · Oct 5, 2010 · acc9a46 · acc9a46
1 parent b498a98
commit acc9a46
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/spidermonkey/error.c b/spidermonkey/error.c
@@ -75,6 +75,14 @@ add_frame(const char* srcfile, const char* funcname, int linenum)
 void
 report_error_cb(JSContext* cx, const char* message, JSErrorReport* report)
 {
+    /* Subtle note about JSREPORT_EXCEPTION: it triggers whenever exceptions
+     * are raised, even if they're caught and the Mozilla docs say you can
+     * ignore it.
+     */
+    /* TODO What should we do about warnings? A callback somehow? */
+    if (report->flags & JSREPORT_WARNING)
+        return;
+
     const char* srcfile = report->filename;
     const char* mesg = message;