Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import performance increase #10

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kostenickj
Copy link

Hi, I don't expect you too use this PR directly, because I think it probably messes things up further down the import pipeline (stuff i don't personally use), but you should consider looking at the code and integrating it in some way.

This massively increases the performance of the importer when importing a gen8 character with a lot of morphs.

The main issue causing a slow is deleting the eyelash morphs after joining the eyelash and body meshes. This is extremely slow and was taking 1+ hour (and still running before i cancelled it) on my machine because blender only lets you delete 1 at a time. You can get around this by naming the eyelash morphs and body morphs the same on each object and THEN joining the objects together. Blender will automatically combine the morphs and you no longer have to delete eyelash morphs. This massively improved performance. I only tested this on gen8 base female so far.

Hope this helps.

With this change to the code it imports in around 5 minutes instead of 1+ hours for me.

kostenickj and others added 3 commits January 10, 2021 04:13
dont join eyelashes until after import because removing the morphs is slow as hell. just rename them and join to body mesh instead after import is finished
@samjay3d
Copy link
Collaborator

Hey there,
Wow, to say that we were excited to see this post is an understatement! I just wanted to reach out to you personally and let you know that there is actually a development team internally at Daz doing the testing and putting together bridge support, and this has gone a long way in helping us continue this support!
One of our plugin devs will be reviewing this and will see what we should add to the bridge. Thank you for taking the time to troubleshoot this problem

@kostenickj
Copy link
Author

That's great to hear, I have a lot of experience with the quirks of blender over the years. Let me know if I can assist.

@samjay3d
Copy link
Collaborator

I will definitely reach out in the future. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants