Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored import statements to use org.junit.Assert #1167

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

tfr42
Copy link
Member

@tfr42 tfr42 commented Aug 10, 2021

This PR contains minor improvements of the usage of JUnit API.

…cated methods in junit.framework.Assert. Upgrades to junit 4.13.2
@tfr42 tfr42 added enhancement enhancement or improvement dependencies Pull requests that update a dependency (library) labels Aug 10, 2021
@tfr42
Copy link
Member Author

tfr42 commented Aug 13, 2021

Introduce constants for different units and measures.

@stephanr
Copy link
Member

From a programmer's point of view it would be nice to use general available constant for most cases and only a local constant if required.
It might also be interesting to derive the general constant from the value previously used by JUnit.

@tfr42 tfr42 added the needs rebase PR is not up to date and needs rebase label Aug 15, 2021
@tfr42 tfr42 removed the needs rebase PR is not up to date and needs rebase label Aug 16, 2021
@tfr42 tfr42 changed the title refactored import statements to use org.junit.Assert Refactored import statements to use org.junit.Assert Dec 1, 2021
@tfr42 tfr42 added the needs rebase PR is not up to date and needs rebase label May 16, 2022
@lgoltz lgoltz removed the needs rebase PR is not up to date and needs rebase label Nov 21, 2022
@lgoltz lgoltz added the needs rebase PR is not up to date and needs rebase label May 22, 2023
@lgoltz lgoltz removed the needs rebase PR is not up to date and needs rebase label Nov 30, 2023
@stephanr stephanr added the needs rebase PR is not up to date and needs rebase label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency (library) enhancement enhancement or improvement in progress needs rebase PR is not up to date and needs rebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants