Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in WPS client: LiteralInputType is missing DefaultValue property #810

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

awst-baum
Copy link
Contributor

@awst-baum awst-baum commented Jan 27, 2017

This request fixes a bug in the WPS client:
Currently, LiteralInputType doesn't handle a literal input's default value which can be announced by a WPS server with the <DefaultValue> tag in the ProcessDescriptions, see Web Processing Service standard version 1.0.0, Table 25 (page 26).

This fix adds a property for it to LiteralInputType and adapts ProcessDetails to parse it from the ProcessDescriptions.
It also adds an optional unit test that is run if demo_wps_url2 and demo_wps_def_processor are set in .deegree-test.properties. These values have to refer to a processor that has at least one default value for a literal input, e.g. http://www.zoo-project.org/cgi-bin/zoo_loader.cgi?Service=WPS&Version=1.0.0&Request=GetCapabilities and raster-tools-src.cgi-env.Gdal_Warp

@tfr42 tfr42 added the bug error issue and bug (fix) label Mar 14, 2017
@tfr42 tfr42 added this to the 3.4 milestone Mar 14, 2017
@tfr42 tfr42 requested a review from lgoltz March 14, 2017 11:08
@tfr42 tfr42 modified the milestones: 3.4, 3.4.1 Apr 6, 2018
@tfr42 tfr42 modified the milestones: 3.4.1, 3.4.2 Jun 18, 2018
@tfr42 tfr42 added the needs rebase PR is not up to date and needs rebase label Jul 6, 2018
@tfr42 tfr42 modified the milestones: 3.4.2, 3.4.3 Jul 7, 2018
@tfr42 tfr42 modified the milestones: 3.4.3, 3.4.4 Sep 28, 2018
@tfr42 tfr42 modified the milestones: 3.4.4, 3.4.5 Mar 1, 2019
@deegree-ci deegree-ci modified the milestones: 3.4.5, 3.4.6 Mar 30, 2019
@tfr42 tfr42 modified the milestones: 3.4.6, 3.4.7 May 11, 2019
@tfr42 tfr42 modified the milestones: 3.4.7, 3.4.8 Jun 14, 2019
@tfr42 tfr42 modified the milestones: 3.4.8, 3.4.9 Jul 8, 2019
@tfr42 tfr42 modified the milestones: 3.4.9, 3.4.10 Sep 6, 2019
@tfr42 tfr42 removed this from the 3.4.10 milestone Oct 25, 2019
@tfr42 tfr42 added the CI failing CI build job fails label Jan 18, 2022
@tfr42 tfr42 added stuck stuck and removed under review labels Nov 30, 2023
@tfr42
Copy link
Member

tfr42 commented Nov 30, 2023

@awst-baum Thank you for your contribution. Unfortunately, it cannot be merged automatically. It cannot be considered for inclusion, before this has been fixed. Please rebase it against the current target branch.

@tfr42 tfr42 added this to the Backlog milestone Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug error issue and bug (fix) CI failing CI build job fails needs rebase PR is not up to date and needs rebase stuck stuck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants