refactor: remove k8s package in favor of using k8s client directly #2513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for zarf-docs canceled.
|
phillebaba
changed the title
phillebaba
force-pushed
the
remove/k8s
branch
2 times, most recently
from
ee3aae8
to
e2a86d7
Compare
|
After working on this for a while I realize that it is going to be very difficult to get a mega change merged without introducing bugs. This is partly due to lack of tests, but also unexplained behavior by some code. I will leave this PR for reference, but will split it into multiple PRs that will leave the k8s package until no dependencies towards it exist anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change removes the k8s package completely. I have attempted to make minimal changes on purpose due to the lack of unit tests. Most of these changes are either moving existing code to a new package or replacing k8s package function calls with calls to the clientset. After this is done we can hopefully start writing unit tests and refactoring the code.
Related Issue
Fixes #2507
Checklist before merging