Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove k8s package in favor of using k8s client directly #2513

Closed
wants to merge 1 commit into from

Conversation

phillebaba
Copy link
Member

Description

This change removes the k8s package completely. I have attempted to make minimal changes on purpose due to the lack of unit tests. Most of these changes are either moving existing code to a new package or replacing k8s package function calls with calls to the clientset. After this is done we can hopefully start writing unit tests and refactoring the code.

Related Issue

Fixes #2507

Checklist before merging

@phillebaba phillebaba requested review from dgershman and a team as code owners May 16, 2024 13:24
@phillebaba phillebaba marked this pull request as draft May 16, 2024 13:24
Copy link

netlify bot commented May 16, 2024

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit fc365ea
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/6647505fd8a5b80008a5420d

@phillebaba phillebaba changed the title refactor: emove k8s package in favor of using k8s client directly refactor: remove k8s package in favor of using k8s client directly May 16, 2024
@phillebaba phillebaba force-pushed the remove/k8s branch 2 times, most recently from ee3aae8 to e2a86d7 Compare May 16, 2024 17:51
@phillebaba
Copy link
Member Author

After working on this for a while I realize that it is going to be very difficult to get a mega change merged without introducing bugs. This is partly due to lack of tests, but also unexplained behavior by some code.

I will leave this PR for reference, but will split it into multiple PRs that will leave the k8s package until no dependencies towards it exist anymore.

@phillebaba
Copy link
Member Author

Closing as most of these things have been split into their own PRs.

@phillebaba phillebaba closed this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove k8s package
1 participant