Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETQ Usager, l'option Autre des champs choix simple devrait inviter à entrer une valeur #10360

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

maatinito
Copy link
Collaborator

Prenoms un champ Choix Simple.
Si l'option Autre est assez commune dans les boutons radio, elle est plus difficile à comprendre dans les listes et les combos.
Cette PR propose d'utiliser un label plus explicite.
Au passage, notez que le label de l'option Autre n'avait pas de translation.
AVANT
image

APRES
image

Notez l'affichage dans les Select
image

Et surtout dans les combos où cela prends plus de sens:

firefox_lVu5yeFNMW

Et la version francaise:
image

Note 1 : suis rouillé au niveau PRs donc n'hésitez pas à demander vos modifs de code.
Note 2 : Pas d'enjeu. Le paradigme Autre est assez ancré et je comprendrais que certains s'y opposent :-)

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.76%. Comparing base (1d2550e) to head (c04803b).
Report is 123 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10360      +/-   ##
==========================================
- Coverage   80.74%   78.76%   -1.98%     
==========================================
  Files        1194     1194              
  Lines       25180    25327     +147     
  Branches     4540     4506      -34     
==========================================
- Hits        20331    19950     -381     
- Misses       4849     5377     +528     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants