New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tech(perf): frozen string literals partout #10386
Draft
colinux
wants to merge
8
commits into
demarches-simplifiees:main
Choose a base branch
from
colinux:frozen-strings
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+4,570
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10386 +/- ##
==========================================
- Coverage 80.79% 79.34% -1.46%
==========================================
Files 1193 1058 -135
Lines 25139 23625 -1514
Branches 4526 4218 -308
==========================================
- Hits 20312 18745 -1567
- Misses 4827 4880 +53 ☔ View full report in Codecov by Sentry. |
See https://github.com/jolmg/parsby/blob/534f8a95b40cd7102bb55abd2a02ef576a9198da/lib/parsby.rb#L572C11-L572C17 Trace: IOError: not modifiable string # parsby-1.1.1/lib/parsby.rb:572:in `ungetc' # parsby-1.1.1/lib/parsby.rb:572:in `ungetc' # parsby-1.1.1/lib/parsby.rb:539:in `block in restore' # parsby-1.1.1/lib/parsby.rb:539:in `each'
…ral string in spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintenant qu'on connait notre bonne couverture de tests, on peut être confiant sur ce genre de changements (+ canary release).
Rappels:
+
devant un string le définit comme mutableCas où des strings doivent rester mutables :
app/models/concerns/tags_substitution_concern.rb
: parser de tags (parsby modifie l'IO)Dans un commit isolé j'ai supprimé du code dans
Dolist::API
à propos de l'envoi d'email avec des attachments, car :J'en ai profité pour rajouter quelques tests sur cette classe qui n'en avait aucun.