fix(biome): run all enabled biome fixers #4763
Conversation
|
@w0rp I have a few other fixes queued up for biome, I just need to make sure I have tests for them and everything. Should I make it all part of one PR or keep them more atomic with separate PRs? |
|
@redbmk I highly doubt that waiting this long for a response is worth it. Maybe you can just handle it how you like. I appreciate your work! |
|
Smaller self-contained PRs are easier to review given limited time maintainers have. Also easier to revert in case something breaks. |
autoload/ale/fixers/biome.vim
Outdated
| let l:apply = '--apply' | ||
|
|
||
| let l:unsafe = ale#Var(a:buffer, 'biome_fixer_apply_unsafe') | ||
| if (l:unsafe is 1 || l:unsafe is v:true) |
There was a problem hiding this comment.
No need to check both 1 and v:true. Simply using if (l:unsafe) should suffice the check. You can make it single line like this:
let l:apply = ale#Var(a:buffer, 'biome_fixer_apply_unsafe') ? '--apply-unsafe' : '--apply'
|
There is a linter issue that causes the test to fail. After that is fixed I can merge this: |
@hsanson Cool I just pushed up a fix that included your oneliner suggestion. That's a lot cleaner, thanks! I checked that linters are passing locally now |
- based on biome config, will format, lint, and/or sort imports - adds variable to apply unsafe fixes, disabled by default fixes: dense-analysis#4754
|
Not sure if it would be an issue in the test runners but I noticed if I run the linter and then fixer tests I get an error. I think if it runs fixers first then linters, it wouldn't show up, but the fix I just pushed lets it work either way. |
fixes: #4754