Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#130: Add default content length to progress bar #286

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

#130: Add default content length to progress bar #286

wants to merge 17 commits into from

Conversation

ndemirca
Copy link
Contributor

Closes #130

@coveralls
Copy link
Collaborator

coveralls commented Apr 12, 2024 •
edited

Pull Request Test Coverage Report for Build 9128203413

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 130 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.3%) to 59.678%
Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/tool/mvn/Mvn.java 3 5.0%
com/devonfw/tools/ide/io/FileAccessImpl.java 127 60.84%
Totals Coverage Status
Change from base Build 9110007150: 0.3%
Covered Lines: 4642
Relevant Lines: 7500
💛 - Coveralls

@ndemirca ndemirca marked this pull request as draft April 12, 2024 09:34
@ndemirca ndemirca marked this pull request as ready for review April 12, 2024 12:45
@ndemirca ndemirca requested a review from VinceHeu April 12, 2024 14:57
hohwille
hohwille reviewed Apr 12, 2024
View reviewed changes
cli/pom.xml Outdated Show resolved Hide resolved
@VinceHeu VinceHeu removed their request for review April 15, 2024 09:30
@ndemirca ndemirca marked this pull request as draft April 15, 2024 14:43
jan-vcapgemini
jan-vcapgemini requested changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix looks quite solid, thanks. I've added some small CR's. After these, the PR should be ready for review.

cli/src/main/java/com/devonfw/tools/ide/io/FileAccessImpl.java Outdated Show resolved Hide resolved
cli/src/test/java/com/devonfw/tools/ide/io/IdeProgressBarTest.java Outdated Show resolved Hide resolved
cli/src/test/java/com/devonfw/tools/ide/io/IdeProgressBarTest.java Outdated Show resolved Hide resolved
@jan-vcapgemini jan-vcapgemini added this to the release:2024.04.001 milestone Apr 15, 2024
@ndemirca ndemirca marked this pull request as ready for review April 16, 2024 15:06
@tobka777 tobka777 requested a review from hohwille April 17, 2024 08:33
jan-vcapgemini
jan-vcapgemini requested changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your last adjustments. I've added some very small CR's.

cli/src/main/java/com/devonfw/tools/ide/io/FileAccess.java Outdated Show resolved Hide resolved
cli/src/main/java/com/devonfw/tools/ide/io/FileAccessImpl.java Show resolved Hide resolved
cli/src/test/java/com/devonfw/tools/ide/io/IdeProgressBarTest.java Outdated Show resolved Hide resolved
@ndemirca ndemirca self-assigned this Apr 25, 2024
@ndemirca ndemirca marked this pull request as draft May 16, 2024 11:02
@ndemirca ndemirca assigned jan-vcapgemini and unassigned ndemirca May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-vcapgemini jan-vcapgemini jan-vcapgemini approved these changes

@hohwille hohwille Awaiting requested review from hohwille

Assignees

@hohwille hohwille

@jan-vcapgemini jan-vcapgemini

Labels
bugfix
Projects
IDEasy board
Status: 🏗 In progress
Milestone
release:2024.04.001
Development

Successfully merging this pull request may close these issues.

ProgressBar AssertionError, if content-length not set
4 participants
@ndemirca @coveralls @hohwille @jan-vcapgemini