-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#12: Implement ToolCommandlet for Android Studio #299
Open
jan-vcapgemini
wants to merge
28
commits into
devonfw:main
Choose a base branch
from
jan-vcapgemini:feature/12-implement-androidstudio-commandlet
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
#12: Implement ToolCommandlet for Android Studio #299
jan-vcapgemini
wants to merge
28
commits into
devonfw:main
from
jan-vcapgemini:feature/12-implement-androidstudio-commandlet
+239
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added Android Studio IdeToolCommandlet with first runIde implementation for Windows and Mac added symlink creation
Pull Request Test Coverage Report for Build 9300272868Details
💛 - Coveralls |
added parameterized installation test
added testAndroidStudioRun test removed postInstall added simulated studio64.exe
removed unnecessary JDK installation (already included in SDK) removed unnecessary readme files and folders added javadocs added studio64.exe to .gitattributes to be handled as text file
added test resources for MacOS run test added old bash script creation (WIP probably not needed at all)
changed FileCopyMode from default to overwrite tree
replaced faulty tool path with open command for MacOS removed postInstall method
# Conflicts: # cli/src/main/java/com/devonfw/tools/ide/commandlet/CommandletManagerImpl.java
mvomiero
reviewed
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice implementation for this commandlet! LGTM 👍
cli/src/main/java/com/devonfw/tools/ide/tool/androidstudio/AndroidStudio.java
Outdated
Show resolved
Hide resolved
changed runAndroidStudio method to private
mvomiero
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
replaced runIde with runTool removed runAndroidStudio method adjusted test
# Conflicts: # .gitattributes
Jonnathanjaquez
approved these changes
May 8, 2024
Jonnathanjaquez
approved these changes
May 8, 2024
Jonnathanjaquez
approved these changes
May 8, 2024
# Conflicts: # cli/src/main/resources/nls/Ide.properties # cli/src/main/resources/nls/Ide_de.properties
…://github.com/jan-vcapgemini/IDEasy into feature/12-implement-androidstudio-commandlet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12
Implements: