Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#12: Implement ToolCommandlet for Android Studio #299

Open
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

jan-vcapgemini
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini commented Apr 17, 2024

Fixes: #12

Implements:

  • added Android Studio IdeToolCommandlet with first runIde implementation for Windows and Mac and Linux.
  • added documentation

added Android Studio IdeToolCommandlet with first runIde implementation for Windows and Mac
added symlink creation
@jan-vcapgemini jan-vcapgemini self-assigned this Apr 17, 2024
@jan-vcapgemini jan-vcapgemini added the android-studio Android Studio IDE from Jet-Brains label Apr 17, 2024
@jan-vcapgemini jan-vcapgemini added this to the release:2024.04.001 milestone Apr 17, 2024
@jan-vcapgemini jan-vcapgemini marked this pull request as draft April 17, 2024 15:03
@coveralls
Copy link
Collaborator

coveralls commented Apr 22, 2024

Pull Request Test Coverage Report for Build 9300272868

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.7%) to 60.414%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/commandlet/CommandletManagerImpl.java 3 89.77%
Totals Coverage Status
Change from base Build 9275378992: 0.7%
Covered Lines: 4730
Relevant Lines: 7538

💛 - Coveralls

jan-vcapgemini and others added 4 commits April 22, 2024 18:19
added parameterized installation test
added testAndroidStudioRun test
removed postInstall
added simulated studio64.exe
removed unnecessary JDK installation (already included in SDK)
removed unnecessary readme files and folders
added javadocs
added studio64.exe to .gitattributes to be handled as text file
@jan-vcapgemini jan-vcapgemini marked this pull request as ready for review April 23, 2024 09:04
added test resources for MacOS run test
added old bash script creation (WIP probably not needed at all)
changed FileCopyMode from default to overwrite tree
replaced faulty tool path with open command for MacOS
removed postInstall method
# Conflicts:
#	cli/src/main/java/com/devonfw/tools/ide/commandlet/CommandletManagerImpl.java
Copy link
Contributor

@mvomiero mvomiero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice implementation for this commandlet! LGTM 👍

Copy link
Contributor

@mvomiero mvomiero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android-studio Android Studio IDE from Jet-Brains
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

Implement ToolCommandlet for Android Studio
5 participants