Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#319: omit already up to date #322

Merged
merged 6 commits into from
May 23, 2024
Merged

#319: omit already up to date #322

merged 6 commits into from
May 23, 2024

Conversation

jan-vcapgemini
Copy link
Contributor

Fixes: #319

Implements:

  • added --quiet option to git pull

@jan-vcapgemini jan-vcapgemini self-assigned this May 8, 2024
@jan-vcapgemini jan-vcapgemini changed the title Fix/319 omit already up to date #319 omit already up to date May 8, 2024
@jan-vcapgemini jan-vcapgemini changed the title #319 omit already up to date #319: omit already up to date May 8, 2024
@coveralls
Copy link
Collaborator

coveralls commented May 8, 2024 •
edited

Pull Request Test Coverage Report for Build 9208777129

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 59.528%
Totals Coverage Status
Change from base Build 9176576832: 0.0%
Covered Lines: 4651
Relevant Lines: 7530
💛 - Coveralls

hohwille
hohwille approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jan-vcapgemini thanks for your PR and the KISS style solution. 👍
Ready for merge.

@hohwille hohwille self-assigned this May 17, 2024
@hohwille
Copy link
Member

As this is still in status in proress I will wait and clarify on Tuesday if we should merge. Maybe you have already local addon changes that you want to push.
However, if you want we can merge as is...

@jan-vcapgemini
Copy link
Contributor Author

jan-vcapgemini commented May 21, 2024 •
edited

I've tested the -q option while being offline using git pull -q.
The result looks good:
fatal: unable to access 'https://github.com/devonfw/ide-urls.git/': Could not resolve host: github.com
This PR can be merged unless we need a more complex solution e.g. a quiet flag in GitContext.

@hohwille hohwille merged commit 8366998 into devonfw:main May 23, 2024
4 checks passed
@hohwille hohwille added this to the release:2024.05.001 milestone May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hohwille hohwille Awaiting requested review from hohwille

Assignees

@hohwille hohwille

@jan-vcapgemini jan-vcapgemini

Labels
bugfix git
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2024.05.001
Development

Successfully merging this pull request may close these issues.

Omit "Already up to date" from git pull
3 participants
@jan-vcapgemini @coveralls @hohwille