Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#331: fixed CobiGen installation #332

Merged
merged 9 commits into from
Jun 13, 2024

Conversation

jan-vcapgemini
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini commented May 14, 2024

Fixes: #331

Implements:

  • replaced jar with tar.gz file (taken from devonfw-ide implementation)
  • added simple install and run tests

replaced jar with tar.gz file (taken from devonfw-ide implementation)
@jan-vcapgemini jan-vcapgemini added cobigen code generator tool bugfix labels May 14, 2024
@jan-vcapgemini jan-vcapgemini self-assigned this May 14, 2024
@coveralls
Copy link
Collaborator

coveralls commented May 14, 2024

Pull Request Test Coverage Report for Build 9499549143

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 60.253%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/tool/cobigen/CobigenUrlUpdater.java 1 0.0%
Totals Coverage Status
Change from base Build 9496980488: 0.4%
Covered Lines: 4719
Relevant Lines: 7537

💛 - Coveralls

added installation test
added run test
@mvomiero mvomiero self-assigned this May 17, 2024
Copy link
Contributor

@mvomiero mvomiero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your implementation, LGTM 🛩️

@mvomiero mvomiero assigned hohwille and unassigned mvomiero May 21, 2024
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jan-vcapgemini thanks for fixing. Even though we consider dropping cobigen from IDEasy (see #335) it is still supported at least in devonfw-ide so already fixing the updater fully makes sense.

@hohwille hohwille added this to the release:2024.06.001 milestone Jun 13, 2024
@hohwille hohwille merged commit 27ecb3a into devonfw:main Jun 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix cobigen code generator tool
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

CobiGen installation is not working properly
4 participants