Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control over accumulating MD quantities #1388

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bhourahine
Copy link
Member

@bhourahine bhourahine commented Feb 6, 2024

  • Control over accumulating MD quantities from input and added excitation energies to md.out
  • In several cases, the non-spin-purified data was written, or provided to some geometry drivers.
  • Marked Delta-SCC runs as not providing electronic entropy (at the moment)
  • Options for band structure, forces and charge accumulation during MD
  • Also rationalise use of the eigenvalue test for solvers.

@bhourahine bhourahine added enhancement UX User experience labels Feb 6, 2024
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: Patch coverage is 80.61224% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 70.78%. Comparing base (e431809) to head (929b661).
Report is 24 commits behind head on main.

Current head 929b661 differs from pull request most recent head 226d7c9

Please upload reports for the commit 226d7c9 to get more accurate results.

Files Patch % Lines
src/dftbp/dftbplus/parser.F90 40.00% 6 Missing ⚠️
src/dftbp/dftbplus/main.F90 86.11% 5 Missing ⚠️
src/dftbp/dftbplus/mainio.F90 88.37% 5 Missing ⚠️
src/dftbp/dftbplus/initprogram.F90 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1388      +/-   ##
==========================================
- Coverage   70.84%   70.78%   -0.06%     
==========================================
  Files         231      231              
  Lines       44186    44220      +34     
==========================================
- Hits        31303    31301       -2     
- Misses      12883    12919      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aradi aradi self-assigned this Feb 8, 2024
@bhourahine bhourahine added this to the 24.2 milestone Mar 12, 2024
@bhourahine
Copy link
Member Author

closes #1378

@bhourahine bhourahine force-pushed the BandOutMD branch 3 times, most recently from 82bdcce to 48ad833 Compare March 15, 2024 00:07
@bhourahine bhourahine marked this pull request as draft March 15, 2024 00:09
@bhourahine bhourahine force-pushed the BandOutMD branch 3 times, most recently from 8044b1f to 5e182bc Compare April 10, 2024 17:27
@bhourahine bhourahine marked this pull request as ready for review April 10, 2024 17:27
@bhourahine bhourahine force-pushed the BandOutMD branch 2 times, most recently from 424b251 to 6b50299 Compare April 17, 2024 14:24
@bhourahine bhourahine requested a review from aradi April 17, 2024 14:31
@bhourahine
Copy link
Member Author

@aradi Delta-DFTB free energy removal separated off as #1440

@bhourahine
Copy link
Member Author

@aradi this is the other half of that split PR (#1440 )

Control over accumulating MD quantities from input and added
excitation energies to md.out

In several cases, the non-spin-purified data was written, or provided
to some geometry drivers.

Options for band structure, forces and charge accumulation during MD.

Also rationalise use of the eigenvalue test for solvers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement UX User experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants