Silence warning about unused callbacks to fix pumactl restart #8434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The callbacks aren't used in cluster mode, and puma prints a warning about that. This is fine, we don't need the callbacks in single-mode, but can still keep it, in case somebody switches on cluster mode. The problem is, the current puma version has a bug, where pumactl crashes when trying to print these warnings, so lets just silence the warnings. People running in single mode also don't need to care about the warnings anyway.
denschub
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callbacks aren't used in cluster mode, and puma prints a warning about that. This is fine, we don't need the callbacks in single mode, but can still keep it, in case somebody switches on cluster mode.
The problem is, the current puma version has a bug (I opened puma/puma#3186 for that), where pumactl crashes when trying to print these warnings, so lets just silence the warnings. People running in single mode also don't need to care about the warnings anyway.
The alternative would be to remove the callbacks, but they don't do any harm when they aren't used, but are maybe useful when somebody wants to enable cluster mode. So as they are already there (even when we never used cluster mode by default), I think keeping them and silence the warning is the better option?