Split up MultiIde.hs into many files #19198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
sw/multi-ide-structure-handling-improvements
to
main
May 23, 2024 15:55
samuel-williams-da
force-pushed
the
sw/multi-ide-restructure
branch
from
fbe8176
to
cd5b92a
Compare
dylant-da
approved these changes
May 27, 2024
samuel-williams-da
added a commit
that referenced
this pull request
May 31, 2024
* Split up MultiIde.hs into many files * Further split SubIde
samuel-williams-da
added a commit
that referenced
this pull request
Jun 3, 2024
* Daml ide multi ide (#17345) * Multi-ide refactors (#18885) * Reimplement ProgressToken prefixing to be stateless * Refactor parsing logic to not use interleaveIO * Move most verbose logging behind a flag * Address reviews * Multi-IDE Features for 2.9 (#19040) * Implement dar unpacking * Implement packageless IDE * Hot-reloading logic for daml.yaml, multi-package.yaml, *.dar * Implement initial error recovery logic * Switch logging to log levels Replace window reload with LanguageServer restart * Forward args from multi-ide to sub-ides * Change unpacked dar paths to be the unit-id. Update unpacking logic to shutdown previous IDEs * Remove broken experimental flag * Refactor ide restart logic to not lose event handlers * Log subIDE errors to debug logger live * Windows fixes * First review fixes batch * Use newtypes for many FilePaths * Address Dylan's comments * Refactor how SubIDEs are passed around, reduce times it is dropped * Update diagnostic * Multi-ide structure change handling (#19194) * Better support for package structure changes * Rename some handlers * Split up MultiIde.hs into many files (#19198) * Split up MultiIde.hs into many files * Further split SubIde * Multi-IDE Sdk install managament (#19256) * Tweaks from previous version * Implement Sdk Version management * Address review * Fix compilation issues * Fix issues with 2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for SDK install work
Mostly just moving code into different files. The only code changes are:
MultiIdeStatefields to start withmissubIDEwithsubIdesubIdeHandlerneeded to be made part of theMultiIdeState, to avoid cyclic dependencies (As it calls to addNewSubIde which calls back to it in another thread)Later I would like to move this out of
damlc, and make it either a haskell dependency, or a binary dependency (and as such, not part ofdamlc-bootstrap)