Add PackageVersion to ContractInstance #19224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remyhaemmerle-da
requested review from
garyverhaegen-da and
gerolf-da
as code owners
remyhaemmerle-da
changed the title
tudor-da
reviewed
May 17, 2024
| @@ -139,6 +141,7 @@ message Versioned { | |||
| message FatContractInstance { | |||
| bytes contract_id = 1; | |||
| string package_name = 9; // required *since dev* | |||
| repeated uint32 package_version = 10; // required *since dev* | |||
There was a problem hiding this comment.
shouldn't we adapt the comments to say since 1.16?
tudor-da
reviewed
May 17, 2024
| @@ -2125,7 +2125,10 @@ private[lf] object SBuiltin { | |||
|
|
|||
| private def extractContractInfo( | |||
| tmplId2TxVersion: TypeConName => TransactionVersion, | |||
| tmplId2PackageName: (TypeConName, TransactionVersion) => Option[PackageName], | |||
| tmplId2PackageName: ( | |||
There was a problem hiding this comment.
Suggested change
| tmplId2PackageName: ( | |
| tmplId2PackageNameVersion: ( |
tudor-da
reviewed
May 17, 2024
| machine.lookupContract(coid) { | ||
| case V.ContractInstance(packageNameVersion, srcTmplId, coinstArg) => | ||
| packageNameVersion match { | ||
| case Some((pkgName, _)) => |
There was a problem hiding this comment.
where is pkgVersion used?
tudor-da
approved these changes
May 17, 2024
|
We will not persist package version for 2.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.