Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daml-Script changes for 2.9 #19225

Merged
merged 4 commits into from
May 21, 2024
Merged

Conversation

samuel-williams-da
Copy link
Contributor

Backport of #19223

Doesn't include the package preference tests, as we don't have the testing structure backported yet
Also adds daml-script-beta as an alias to daml3-script in the daml.yaml, with a slightly different warning

@samuel-williams-da samuel-williams-da requested a review from a team May 16, 2024 15:04
@samuel-williams-da samuel-williams-da changed the title Sw/daml script 2.9 changes 2.x Daml-Script changes for 2.9 May 16, 2024
@samuel-williams-da
Copy link
Contributor Author

Also, haven't yet found a nicer name for concurrently, open to suggestions

Copy link
Contributor

@paulbrauner-da paulbrauner-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making all these necessary changes quickly! Have you tested that daml-script-beta works as intended?

@paulbrauner-da
Copy link
Contributor

Also, haven't yet found a nicer name for concurrently, open to suggestions

concurrently is canon in haskell land https://hackage.haskell.org/package/async-2.2.5/docs/Control-Concurrent-Async.html#v:concurrently :)

@samuel-williams-da
Copy link
Contributor Author

Thanks for making all these necessary changes quickly! Have you tested that daml-script-beta works as intended?

Yes :)

concurrently is canon in haskell land

Right, but in haskell land it does a lot more than this one!

Co-authored-by: Paul Brauner <141240651+paulbrauner-da@users.noreply.github.com>
@samuel-williams-da samuel-williams-da merged commit 1aa17d4 into main-2.x May 21, 2024
17 checks passed
@samuel-williams-da samuel-williams-da deleted the sw/daml-script-2.9-changes-2.x branch May 21, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants