This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
Bug Fix for basicpackage #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Test egg_info can be run | ||
| proc = subprocess.Popen( | ||
| [sys.executable, setup, 'egg_info'], | ||
| shell=False, | ||
| stdout=subprocess.PIPE) | ||
| stdout=subprocess.PIPE, | ||
| cwd=tmp.path) |
There was a problem hiding this comment.
Run setup.py in the tmp.path directory rather than
tmp.path/setup.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi I have been finding that the basic-package example does not work as it should.
I have found that the package_dir directive in setup.py_tmpl is incorrect. I have removed this declaration and changed the unit_test to run
$python setup.py --xxxxx
In the tmp directory rather than
$python temp_dir/setup.py --xxxxx
I have noticed that setup.py scripts in general do not behave well when not run in their directory.
Stu
PS have not checked with namespace packages yet