Refs #29299 -- Add type annotations to gettext. #12544
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamchainz
reviewed
Mar 9, 2020
| @@ -88,7 +88,7 @@ def ugettext_noop(message): | |||
| return gettext_noop(message) | |||
|
|
|||
|
|
|||
| def gettext(message): | |||
| def gettext(message: str) -> str: | |||
There was a problem hiding this comment.
I'm not sure this is accurate. The underlying gettext() function for when translations are active doesn't seem to make guarantees about type, and uses mark_safe in the case of messages that are already SafeData:
django/django/utils/translation/trans_real.py
Line 275 in eb77e80
|
DEP 65 is still on a draft stage so we don't accept type annotations for now. |
|
Ok thanks Mariusz. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can add more of these if patches like these are welcome. They would help our project, if present.