OLAP functionality. #27646 #12807
Closed
OLAP functionality. #27646 #12807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'# Please enter the commit message for your changes. Lines starting
atombrella
force-pushed
the
olap_functionality
branch
from
5cbcb3a
to
8c748ae
Compare
|
@adamchainz @hannseman You've both set yourself as watchers on the ticket. I think it's difficult to solve this without including a new method for manually controlling this. I need to add a link to the mailing list thread for this in this PR. |
adamchainz
reviewed
Aug 31, 2020
Comment on lines
+29
to
+31
| def __init__(self, query: Query, connection, using): | ||
| self.custom_group_by = False | ||
| self.query = query # type: Query |
There was a problem hiding this comment.
we don't do type hints yet as per django/deps#65 and corresponding mailing list
There was a problem hiding this comment.
I know! :) It's just for personal use while developing this. IDE assistance is considerably better with
|
@adamchainz https://groups.google.com/g/django-developers/c/8WVd64QaOfE/m/U7q8XelMBAAJ is the mailing list discussion about this. |
Co-authored-by: Adam Johnson <me@adamj.eu>
|
Closing due to inactivity. @atombrella Feel-free to send a new patch when you have time, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's rather in-complete, and basically only an outline of how I think ticket #27646 could be approached. I don't see an easy way to solve this ticket, without introducing a manual method for dealing with the group by clause. @adamchainz mentioned on IRC that the name might make people who know SQL to use this without considering that Django by default does a good job of handling this for you, when using
QuerySet.annotate.I'll write a post about this to the mailing list later, as Tim Graham requested this.
It's only a draft. I think targeting this at 3.2 would seem possible. No tests are in this draft (it's cumbersome to write them, and I'd like to have some simplicity).