Refs #34007 -- Added Q.referenced_based_fields property #18093
Merged
+41
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
nessita
reviewed
Apr 22, 2024
There was a problem hiding this comment.
Thank you @shangxiao for this work. Looks good!
I saw in the PR description that you are wondering about how correct is to switch to cached_property. I am too! Was there a specific reason to choose this switch? Tagging @charettes to seek help answering this.
|
@nessita I think that using a |
felixxm
reviewed
Apr 25, 2024
sarahboyce
force-pushed
the
refs_34007_referenced_base_fields
branch
from
08742a8
to
d648bd7
Compare
sarahboyce
force-pushed
the
refs_34007_referenced_base_fields
branch
from
d648bd7
to
fb69337
Compare
nessita
approved these changes
May 2, 2024
sarahboyce
force-pushed
the
refs_34007_referenced_base_fields
branch
from
fb69337
to
bd7d4d3
Compare
Thank you to Mariusz Felisiak and Natalia Bidart for the reviews.
sarahboyce
force-pushed
the
refs_34007_referenced_base_fields
branch
from
bd7d4d3
to
e9080cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs ticket-34007 & ticket-35359
Cherry picked from #16054 to be used in #18068
Notes:
@propertyinto@cached_property, this wasn't reviewed so will need to be confirmed whether this is acceptable