Skip to content

Commit

Permalink
add a 'subject' result to messageFormatter
Browse files Browse the repository at this point in the history
  • Loading branch information
James Porter authored and Dustin J. Mitchell committed Jan 4, 2010
1 parent 3ac0d83 commit 04c92fc
Showing 1 changed file with 13 additions and 7 deletions.
20 changes: 13 additions & 7 deletions buildbot/status/mail.py
Expand Up @@ -315,6 +315,11 @@ def defaultMessage(self, mode, name, build, results, master_status):
and type."""
result = Results[results]

subject = self.subject % { 'result': Results[results],
'projectName': master_status.getProjectName(),
'builder': name,
}

text = ""
if mode == "all":
text += "The Buildbot has finished a build"
Expand Down Expand Up @@ -371,17 +376,21 @@ def defaultMessage(self, mode, name, build, results, master_status):
text += "sincerely,\n"
text += " -The Buildbot\n"
text += "\n"
return (text, 'plain')
return (subject, text, 'plain')

def buildMessage(self, name, build, results):
if self.customMesg:
# the customMesg stuff can be *huge*, so we prefer not to load it
attrs = self.getCustomMesgData(self.mode, name, build, results, self.master_status)
text, type = self.customMesg(attrs)
subject = self.subject % { 'result': Results[results],
'projectName': self.master_status.getProjectName(),
'builder': name,
}
elif self.messageFormatter:
text, type = self.messageFormatter(self.mode, name, build, results, self.master_status)
subject, text, type = self.messageFormatter(self.mode, name, build, results, self.master_status)
else:
text, type = self.defaultMessage(self.mode, name, build, results, self.master_status)
subject, text, type = self.defaultMessage(self.mode, name, build, results, self.master_status)

assert type in ('plain', 'html'), "'%s' message type must be 'plain' or 'html'." % type

Expand All @@ -404,10 +413,7 @@ def buildMessage(self, name, build, results):
m.set_type("text/%s" % type)

m['Date'] = formatdate(localtime=True)
m['Subject'] = self.subject % { 'result': Results[results],
'projectName': self.master_status.getProjectName(),
'builder': name,
}
m['Subject'] = subject
m['From'] = self.fromaddr
# m['To'] is added later

Expand Down

0 comments on commit 04c92fc

Please sign in to comment.