Skip to content

Commit

Permalink
fix: background image relative to css
Browse files Browse the repository at this point in the history 
Signed-off-by: Dustin J. Mitchell <dustin@zmanda.com>
  • Loading branch information
Tobias Oberstein authored and Dustin J. Mitchell committed Apr 11, 2010
1 parent cf37d94 commit 0b79486
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion buildbot/status/web/files/default.css
View file
Expand Up @@ -4,7 +4,7 @@ body.interface {
margin-top: 20px;
margin-bottom: 50px;
padding: 0;
background: url(/bg_gradient.jpg) repeat-x;
background: url("./bg_gradient.jpg") repeat-x;
font-family: Verdana, Cursor;
font-size: 10px;
font-weight: bold;
Expand Down

4 comments on commit 0b79486

@djmitche
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I was wrong -- URLs in CSS files are relative to the CSS file, not the parent HTML document (e.g., http://haacked.com/archive/2006/01/12/CSSURLReferencesAndURLRewriting.aspx).

However, from what I can tell that should use single-, not double-quotes. Right?

@oberstet
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, relative to css and maybe it shouldnt contain single nor double quotes .. now i think it should be just:

background: url(bg_gradient.jpg) repeat-x;

@djmitche
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@marcus-sonestedt
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And tested (on my non-root buildbot instance at work) ! ;)

Please sign in to comment.